Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get genesis validation checks running in CI. #513

Closed
geoknee opened this issue Aug 27, 2024 · 1 comment
Closed

Get genesis validation checks running in CI. #513

geoknee opened this issue Aug 27, 2024 · 1 comment
Assignees

Comments

@geoknee
Copy link
Collaborator

geoknee commented Aug 27, 2024

Prereq for merging #489

The checks for genesis validation require a specific set of tool versions to be installed in the docker image in which the validation script runs - some of these tool versions are known at build time, whereas some other tool versions such as go is derived from the go.mod file at the commit at which the validation runs. We currently use the image ci-builder:v0.49.0 for running the all jobs in superchain registry. The image is built from this Dockerfile. So far, we have explored two options to install the correct tool versions to get the genesis validation checks to run on CI runner:

  • Install the required tool versions (nvm, go etc.) as pre-req steps in the Circle CI job that is being executed. With this approach, we are observing that the tool versions/settings aren't taking effect when running the actual validation.

  • Modify the base image dockerfile to install the required tools in to the base image. I have been unable to build the image locally so far, even without changes (hitting timeout errors and such).

Continuing to explore both options.

@geoknee
Copy link
Collaborator Author

geoknee commented Aug 28, 2024

The list of requirements are:

foundry
gvm
nvm
just
pnpm
yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants