Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing condition for LoopIntervalMsec that causes issues #49

Merged
merged 3 commits into from
Aug 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
removing condition for LoopIntervalMsec that causes issues
  • Loading branch information
raffaele-oplabs committed Aug 13, 2024
commit 30934c36fa873eed9dbcebc61d4f5798addb76af
5 changes: 0 additions & 5 deletions op-monitorism/withdrawals/cli.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package withdrawals

import (
"errors"
"fmt"

"github.com/ethereum/go-ethereum/common"
Expand Down Expand Up @@ -40,10 +39,6 @@ func ReadCLIFlags(ctx *cli.Context) (CLIConfig, error) {
StartingL1BlockHeight: ctx.Uint64(StartingL1BlockHeightFlagName),
}

if cfg.LoopIntervalMsec == 0 {
raffaele-oplabs marked this conversation as resolved.
Show resolved Hide resolved
return cfg, errors.New("no loop interval configured")
}

portalAddress := ctx.String(OptimismPortalAddressFlagName)
if !common.IsHexAddress(portalAddress) {
return cfg, fmt.Errorf("--%s is not a hex-encoded address", OptimismPortalAddressFlagName)
Expand Down