Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing condition for LoopIntervalMsec that causes issues #49

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

raffaele-oplabs
Copy link
Contributor

Description

removing condition for LoopIntervalMsec that causes issues

Tests

tested locally.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

…`--loop.interval.msec 12000` to ensure this is consitent with the rest.
@Ethnical
Copy link
Collaborator

Ethnical commented Aug 13, 2024

@raffaele-oplabs I fixed the issue, the flag LoopIntervalMsec was not setup and forgotten since the beginning of the code. This is better to setup this one to be consistent and get the interval and treat the interval in case the value is set to 0.

9c27845ffccfb51af3c5e66df14f8125d119abcffd0149daade4033bc2f5c60f

CLI used:

go run ../cmd/monitorism withdrawals  --l1.node.url https://proxyd-l1-consensus.primary.mainnet.prod.oplabs.cloud --loop.interval.msec 12000 --optimismportal.address 0xbEb5Fc579115071764c7423A4f12eDde41f106Ed --start.block.height 20515297 --l2.node.url https://proxyd-l2-consensus.primary.mainnet.prod.oplabs.cloud

Copy link
Collaborator

@Ethnical Ethnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raffaele-oplabs I am approving this new changed after tested as expected (see the comment above).

@Ethnical Ethnical added the bug Something isn't working label Aug 14, 2024
@raffaele-oplabs raffaele-oplabs merged commit 54f0c69 into main Aug 14, 2024
4 checks passed
@raffaele-oplabs raffaele-oplabs deleted the fix-bugs-on-monitorism branch August 14, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants