Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update github.com/{gogo,golang}/protobuf #8084

Merged
merged 2 commits into from
Jun 13, 2017

Conversation

heyitsanthony
Copy link
Contributor

Fixes #7787

@xiang90
Copy link
Contributor

xiang90 commented Jun 12, 2017

lgtm

@gyuho
Copy link
Contributor

gyuho commented Jun 12, 2017

Should we bump the protoc version as well? 3.3 is out https://github.com/google/protobuf/releases.

@heyitsanthony
Copy link
Contributor Author

bumped to 3.3; the codegen is the same

@gyuho
Copy link
Contributor

gyuho commented Jun 12, 2017

lgtm. thanks

@codecov-io
Copy link

Codecov Report

Merging #8084 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8084      +/-   ##
==========================================
+ Coverage   76.49%   76.52%   +0.02%     
==========================================
  Files         342      342              
  Lines       26549    26568      +19     
==========================================
+ Hits        20309    20330      +21     
+ Misses       4785     4782       -3     
- Partials     1455     1456       +1
Impacted Files Coverage Δ
etcdserver/api/v3rpc/lease.go 92.85% <0%> (-7.15%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
clientv3/concurrency/election.go 80% <0%> (-2.41%) ⬇️
lease/leasehttp/http.go 62.59% <0%> (-1.53%) ⬇️
proxy/grpcproxy/lease.go 88.57% <0%> (-0.96%) ⬇️
etcdserver/api/v3rpc/watch.go 92.48% <0%> (-0.94%) ⬇️
etcdserver/v3_server.go 71.49% <0%> (-0.24%) ⬇️
pkg/adt/interval_tree.go 89.02% <0%> (+0.3%) ⬆️
mvcc/watchable_store.go 87.59% <0%> (+0.77%) ⬆️
etcdmain/etcd.go 46.35% <0%> (+0.85%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933aa09...4ebeba0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants