Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Update coreos/etcd #5

Closed
wants to merge 1 commit into from
Closed

Update coreos/etcd #5

wants to merge 1 commit into from

Conversation

irfansharif
Copy link
Contributor

@irfansharif irfansharif commented Jul 25, 2017

This is needed to pick up etcd-io/etcd@a92ceee, etcd-io/etcd@93826f2 (etcd-io/etcd#8288). Part of cockroachdb/cockroach#16950.

github.com/coreos/etcd/raft/node_test.go       |   32 +++
github.com/coreos/etcd/raft/raft.go            |   72 +++++--
github.com/coreos/etcd/raft/raft_test.go       |  160 +++++++++++++-
github.com/coreos/etcd/raft/raftpb/raft.pb.go  |   76 +++++--
github.com/coreos/etcd/raft/read_only.go       |    2 +-
github.com/coreos/etcd/raft/status.go          |   18 +-

This picks up etcd-io/etcd#7987 which we don't use as yet, so should be fine. Also picks up etcd-io/etcd#7761 which should be fine. raft/raftpb/raft.pb.go was regenerated in etcd-io/etcd#8084, which I'm less sure about, is this safe for us?

+cc @bdarnell

@tamird
Copy link
Contributor

tamird commented Jul 25, 2017 via email

@bdarnell
Copy link
Contributor

etcd-io/etcd#8084 looks fine for us; the only change is to the unmarshal error (which looks like it's laying the groundwork for upgrading to the packed repeated int format, without actually changing anything yet)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants