Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clippy fixes + msrv bump #354

Closed
wants to merge 3 commits into from
Closed

Conversation

bconn98
Copy link
Collaborator

@bconn98 bconn98 commented Mar 1, 2024

Fixes #353

@bconn98 bconn98 requested review from estk and gadunga as code owners March 1, 2024 04:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.07%. Comparing base (c981ca4) to head (049e2cc).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   63.01%   63.07%   +0.05%     
==========================================
  Files          24       24              
  Lines        1560     1557       -3     
==========================================
- Hits          983      982       -1     
+ Misses        577      575       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bconn98
Copy link
Collaborator Author

bconn98 commented Mar 3, 2024

@estk Should be all set, backed out the msrv bump

@Dirreke Dirreke mentioned this pull request Mar 3, 2024
@bconn98
Copy link
Collaborator Author

bconn98 commented Mar 3, 2024

OBE, closing. Changes merged in #361

@bconn98 bconn98 closed this Mar 3, 2024
@bconn98 bconn98 deleted the clippy_msrv_fix branch March 3, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy fails with log4rs
3 participants