-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trigger onstartup
#343
Conversation
@estk Yup will do, I was waiting on the checks. Hadn't looked close enough to realize it was just the 1.67 issue |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 63.39% 63.56% +0.17%
==========================================
Files 24 25 +1
Lines 1557 1570 +13
==========================================
+ Hits 987 998 +11
- Misses 570 572 +2 ☔ View full report in Codecov by Sentry. |
It can also close #250 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to review the trigger, rest looks good
@Dirreke thanks for your continued work hard work on this. One last comment, but looking excellent otherwise! |
Thanks. I don't have envs at the moment. I think I will do it after 02/16. |
Bump MSRV to 1.70 for toml |
Only concern I have here is bumping MSRV, the goal is to support at least a year old compiler. Any way we can avoid that? |
Toml started bumping like crazy. I locked it in my branches at the current, but we can lock it at the previous and maintain 1.69.
|
I will rebase it after #354 |
Feel free to rebase now @Dirreke |
Head branch was pushed to by a user without write access
Add trigger onstartup, ref: log4j