use getConfiguration launch to read debug config #1261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read launch.json configuration using vscode.workspace.getConfiguration instead to avoid trail comma issues. Add
initialBreakpoint
as launch.json argument to define initial breakpoint to set in default initCommands.Fixes #1253
Fixes #1259
Type of change
Steps to test this pull request
Say you have a launch.json with trailing comma like this:
If you click the debug button in the status bar
ESP-IDF: Debug
it was not working. With this PR, it should work now.When you start a debug session, the program will stop by default in
app_main
. If you want it NOT to stop at app_main you should set:Expected behaviour:
Expected output:
How has this been tested?
Manual testing by debugging with status bar debug icon
ESP-IDF: Debug
any esp-idf project with launch.json as shown before.Test Configuration:
Checklist