-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Option to omit stopping at app_main (VSC-1438) #1253
Comments
So by default the new debug adapter has these init commands (not written in launch.json itself but in extension code): "initCommands": [
"set remote hardware-watchpoint-limit {IDF_TARGET_CPU_WATCHPOINT_NUM}",
"mon reset halt",
"maintenance flush register-cache",
"thb app_main"
], You can open the launch.json and modify "initCommands": [
"set remote hardware-watchpoint-limit {IDF_TARGET_CPU_WATCHPOINT_NUM}",
"mon reset halt",
"maintenance flush register-cache"
], |
Should be good enough as a workaround but suboptimal as the solution. Startup commands can change after extension update and one must inspect source code after every release to match custom commands On the other hand, cortex debug has |
How about we add the I'm trying to keep default behavior as default as possible. Although is possible to add something like |
I don't have a solid opinion on that. It depends on what most users need (or what you think would be good default). If it'd be the default with no options added I am fine with it since I don't use break on entry point that often and manual breakpoint is what I'd do anyway. This is usual behaviour for most debugging in non-embedded space so it doesn't seem like a big deal. Another option is to make config parameter that controls adding Another option is to make config parameter controlling adding All in all, any of these will be fine as long as it is documented. |
I've made these changes in #1261 You can try these changes using this vsix installer to see if it works for you. Same for the trailing comma issue here. |
Doesn't seem to be working. App still stopping on Extension is updated though, because I don't see an issue with trailing comma anymore. |
I do see that it's trying to continue though, so command itself gets executed:
There is some warning though but I don't know if it has any relevance:
|
@gudvinr Can you try this vsix installer ? Setting |
Seems to be working. According to logs, |
Thanks, much appreciated |
If you find the extension useful. Please leave us a review in the Visual Studio Code Marketplace |
Is your feature request related to a problem? Please describe.
I never break on
app_main
entry unless I want to specifically debug startup process from get-go.You can't simply set breakpoint whenever you want and then build, flash and wait for breakpoint to trigger.
You need to wait for app_main triggering first and then continue.
Describe the solution you'd like
Add an option to suppress breaking on
app_main
.esp_debug_backend
already hasstart_func
parameter inexec_run
, which can be set to empty string to skip adding breakpoint.Describe alternatives you've consideredAdditional contextThe text was updated successfully, but these errors were encountered: