Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand lcd/i80_controller example to support ILI9341 display (IDFGH-7775) #9311

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Expand lcd/i80_controller example to support ILI9341 display (IDFGH-7775) #9311

merged 3 commits into from
Jul 19, 2022

Conversation

PaintYourDragon
Copy link
Contributor

This replaces #9266 (closed yesterday as the wrong approach). i80 LCD example is extended to show ILI9341 usage; nearly but not quite the same as ST7789, requires no driver changes, just user code. If nothing else, the addition of .flags.swap_color_bytes being the reverse of the corresponding LvGL setting might be worth keeping.
Tested on ESP32-S3-DevKitC-1 N8R8 with Adafruit ILI9341 breakout (8-bit parallel interface).

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jul 7, 2022
@github-actions github-actions bot changed the title Expand lcd/i80_controller example to support ILI9341 display Expand lcd/i80_controller example to support ILI9341 display (IDFGH-7775) Jul 7, 2022
Copy link
Collaborator

@suda-morris suda-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @PaintYourDragon I like this solution! Thank you for your contribution!

@PaintYourDragon
Copy link
Contributor Author

Changes made as requested. Thank you for looking!
Deleted both set_gap lines that were 0,0 rather than leave them in; ONLY the ST7789 sets a gap. Confirmed the gap defaults are always 0; this is implicit as the panel_t structure is calloc’d (which sets allocated memory to 0).

@suda-morris
Copy link
Collaborator

sha=148ce09d97a46602f58791d67db37bfd0f20b751

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Jul 8, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Jul 8, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: In Progress Work is in progress labels Jul 8, 2022
@espressif-bot espressif-bot merged commit 35f7554 into espressif:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally Status: Reviewing Issue is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants