Add ILI9341 and GC9A01 LCD controllers into components. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
ILI9341 tested only on SPI. |
|
Waiting for fix in rainmaker: espressif/esp-rainmaker#133 |
tore-espressif
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
@espzav LGTM!
Just two things:
- Could you add
component/lcdfolder to https://github.com/espressif/esp-bsp/blob/master/test_app/CMakeLists.txt#L9 and check that the new components are built in the CI action? - Not related to this PR, but since we're here: Could you please update our CI upload action as described here https://github.com/espressif/github-actions/blob/master/upload_components/README.md#deprecated-use-espressifupload-components-ci-action-instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two LCD controllers into components and into component manager.
The GC9A01 is only copied from ESP-IDF example and made the component from it.
The ILI9341 is changed for right initialization of the controller. Tested on prepared example for ESP-IDF.