Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile to create Images with no git safe directory restrictions [v5.1 backport] (IDFGH-11514) #12640

Closed

Conversation

timoxd7
Copy link
Contributor

@timoxd7 timoxd7 commented Nov 21, 2023

Problem

If a folder is mounted to the docker container that is not owned by the running user, git disallows the direct access without explicit set of a safe directory. This can happen for example if using wsl on Windows while using a repository on the Windows Filesystem.

Fix

Just set every folder as safe for git, as this implies no security risk in a docker container, solving the issue to not be able to access certain git repositories.

Reference

The github action for ESP-IDF Builds solved this by adding the command before running the actual action command (See espressif/esp-idf-ci-action#27)

Info

This is a backport of #12636

@timoxd7 timoxd7 changed the title Fix Dockerfile to create Images with no git safe directory restrictions (v5.1 backport) Fix Dockerfile to create Images with no git safe directory restrictions [v5.1 backport] Nov 21, 2023
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 21, 2023
@github-actions github-actions bot changed the title Fix Dockerfile to create Images with no git safe directory restrictions [v5.1 backport] Fix Dockerfile to create Images with no git safe directory restrictions [v5.1 backport] (IDFGH-11514) Nov 21, 2023
@dobairoland
Copy link
Collaborator

We only accept PRs for the master branch. It is enough to state in #12636 clearly that you'd like this to be backported to v5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants