Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile with variable depth parameter [v5.1 backport] (IDFGH-11515) #12639

Conversation

timoxd7
Copy link
Contributor

@timoxd7 timoxd7 commented Nov 21, 2023

Problem

If a docker image is built from a branch that has a commit offset in respect to the last tag while using IDF_CLONE_SHALLOW, the git describe will fail returning "1".

Fix

Add another parameter to specify the depth instead of falling back to "1". If set to the offset of the commit +1, the git describe works again, still without cloning the whole repository. For custom IDF and development builds, this helps to get a working build version number again, instead of just "1" being put into the build es ESP IDF Version.

Info

This is a Backport of #12637

@timoxd7 timoxd7 changed the title Dockerfile with variable depth parameter (v5.1 backport) Dockerfile with variable depth parameter [v5.1 backport] Nov 21, 2023
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 21, 2023
@github-actions github-actions bot changed the title Dockerfile with variable depth parameter [v5.1 backport] Dockerfile with variable depth parameter [v5.1 backport] (IDFGH-11515) Nov 21, 2023
@dobairoland
Copy link
Collaborator

As I pointed out here, please point out in #12637 that you'd like to have it in v5.1.

@timoxd7
Copy link
Contributor Author

timoxd7 commented Nov 21, 2023

@dobairoland Did not know that, will keep it in mind for future PRs. Thank you, i will close this now.

@timoxd7 timoxd7 closed this Nov 21, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Won't Do This will not be worked on and removed Status: Opened Issue is new labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants