Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo on "if (!client->send();) return 0;" #17

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

bmedici
Copy link

@bmedici bmedici commented May 17, 2023

No description provided.

@nwash57
Copy link

nwash57 commented Jun 3, 2023

Really wish one of the (many) forks of this library had an active maintainer... Such a simple fix I'm going to be forced to fork and apply myself to get CI working in my project.

@s00500
Copy link

s00500 commented Aug 3, 2023

I also need this fixed :-(

@asjdf
Copy link

asjdf commented Aug 15, 2023

Dear @jesserockz ,
Sorry to bother you, but I realize my previous PR introduced an issue and this PR should fix it, do you have time to help review this PR? Thanks a lot for your contribution to this lib.❤️

Copy link

@nwash57 nwash57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested this exact change on my own fork and it resolves the compilation issue.

@jesserockz jesserockz merged commit c22f062 into esphome:master Aug 17, 2023
@jesserockz jesserockz mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants