Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AsyncWebSocket.cpp #11

Closed
wants to merge 1 commit into from
Closed

Update AsyncWebSocket.cpp #11

wants to merge 1 commit into from

Conversation

CRSLEE
Copy link

@CRSLEE CRSLEE commented Feb 19, 2023

No description provided.

@cgmartin cgmartin mentioned this pull request Feb 20, 2023
@thorrak
Copy link

thorrak commented Feb 21, 2023

+1 on this

@bjun626
Copy link

bjun626 commented Mar 12, 2023

+1

1 similar comment
@munzili
Copy link

munzili commented Mar 21, 2023

+1

@rob040
Copy link

rob040 commented Aug 15, 2023

@asjdf: This change (#10) causes compilation error in platformIO esp32:

Compiling .pio\build\esp32dev_dbg\liba26\ESPAsyncWebServer-esphome\AsyncWebSocket.cpp.o
.pio/libdeps/esp32dev_dbg/ESPAsyncWebServer-esphome/src/AsyncWebSocket.cpp: In function 'size_t webSocketSendFrame(AsyncClient*, bool, uint8_t, bool, uint8_t*, size_t)':
.pio/libdeps/esp32dev_dbg/ESPAsyncWebServer-esphome/src/AsyncWebSocket.cpp:105:7: warning: init-statement in selection statements only available with -std=c++17 or -std=gnu++17
   if (!client->send();) return 0;
       ^
.pio/libdeps/esp32dev_dbg/ESPAsyncWebServer-esphome/src/AsyncWebSocket.cpp:105:23: error: expected primary-expression before ')' token
   if (!client->send();) return 0;
                       ^
*
** [.pio\build\esp32dev_dbg\liba26\ESPAsyncWebServer-esphome\AsyncWebSocket.cpp.o] Error 1

Removing the ';' solves the error.

@asjdf
Copy link

asjdf commented Aug 16, 2023

I noticed this issue and previous PR #17 could fix this issue too, thanks for your notice and I am trying to contact the maintainer of this lib.❤️

@jesserockz
Copy link
Member

Apologies this was not noticed and merged earlier.
Closing as #17 has been merged.

@jesserockz jesserockz closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants