Refactor get_interventions_data #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deprecate function with warning - adds lifecycle deprecated warning with link to Oxford policy tracker - retains use for downloading; download/clean mostly uses existing code - adds documentation explaining depreciation and link to alternatives
seabbs
approved these changes
Mar 27, 2021
seabbs
requested changes
Mar 27, 2021
|
Ah thanks. On the docs I was following the lifecycle vignette: but very happy to export as a normal function. |
|
Ah I didn't know that worked like that. Sounds like a great idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interventions data stopped updating in December 2020. This function is for backwards-compatibility only. Function is now deprecated with warning.
This PR:
mainFixes #164