Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_interventions #164

Closed
seabbs opened this issue Mar 19, 2021 · 3 comments · Fixed by #456
Closed

Refactor get_interventions #164

seabbs opened this issue Mar 19, 2021 · 3 comments · Fixed by #456
Labels
enhancement New feature or request no-issue-activity

Comments

@seabbs
Copy link
Contributor

seabbs commented Mar 19, 2021

Currently removed and may not be needed in the refactored package. This is open for discussion and as far as I am aware this function is currently unused. Partly its inclusion depends on the direction of the package (are we focussing down to just notification data or keeping the wider focus).

If it is included need to be refactored to allow for testing downloading and cleaning individually.
@seabbs seabbs added the enhancement New feature or request label Mar 19, 2021
@seabbs
Copy link
Contributor Author

seabbs commented Mar 26, 2021

Bumping this to 0.9.1. Lets put back in as is with some big lifecycle warnings.

@kathsherratt kathsherratt mentioned this issue Mar 27, 2021
Merged
@github-actions
Copy link

This issue has been flagged as stale due to lack of activity

@github-actions github-actions bot closed this as completed Jun 2, 2021
@seabbs seabbs reopened this Jun 2, 2021
@seabbs seabbs reopened this Jun 10, 2021
@seabbs seabbs reopened this Jun 18, 2021
@seabbs seabbs reopened this Jun 26, 2021
@github-actions github-actions bot closed this as completed Jul 4, 2021
@seabbs seabbs reopened this Jul 5, 2021
@seabbs seabbs reopened this Jul 13, 2021
@kathsherratt kathsherratt reopened this Jul 21, 2021
@seabbs seabbs reopened this Jul 29, 2021
@github-actions github-actions bot closed this as completed Aug 6, 2021
@seabbs seabbs reopened this Aug 6, 2021
@seabbs
Copy link
Contributor Author

seabbs commented Aug 6, 2021 •
edited
Loading

I'm going to vote for removing this and say we should close this issue and remove the function.

@epiforecasts/covidregionaldata any dissent.

@seabbs seabbs mentioned this issue Feb 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depreciations epiforecasts/covidregionaldata
2 participants
@seabbs @kathsherratt