[3.1] Use signed transaction for PUSH_CREATE action deep-mind logging. #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jul 12, 2022
This was referenced Jul 13, 2022
|
Great, seems to work. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #651
Looking at the deep-mind plugin, the version that has been integrated into eosio v2.1 writes signed transactions into the dmlog on
PUSH_CREATEdeferred transactions, see here.The current mandel seems to use the packed transaction instead though, see here. This should be only used for
MODIFY_CREATEwhilePUSH_CREATEshould write the signed transaction.