Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep-mind writes packed transaction instead of signed one on DTRX_OP PUSH_CREATE #651

Closed
fschoell opened this issue Jul 12, 2022 · 1 comment
Closed

deep-mind writes packed transaction instead of signed one on DTRX_OP PUSH_CREATE #651

fschoell opened this issue Jul 12, 2022 · 1 comment
Assignees
@oschwaldp-oci
Labels
3.1 Candidates OCI OCI working this issue...
Milestone
Mandel 3.1.0-rc3

Comments

@fschoell
Copy link

Looking at the deep-mind plugin, the version that has been integrated into eosio v2.1 writes signed transactions into the dmlog on PUSH_CREATE deferred transactions, see here.

The current mandel seems to use the packed transaction instead though, see here. This should be only used for MODIFY_CREATE while PUSH_CREATE should write the signed transaction.
@matthewdarwin matthewdarwin added this to the Mandel 3.1.0 milestone Jul 12, 2022
@heifner heifner added the OCI OCI working this issue... label Jul 12, 2022
@arhag arhag moved this to Todo in ENF Engineering Jul 12, 2022
oschwaldp-oci added a commit that referenced this issue Jul 12, 2022
@oschwaldp-oci
GH-651 Use signed trasaction for PUSH_CREATE action deep-mind logging.
e726b77
This was referenced Jul 12, 2022
Merged
Closed
@heifner heifner moved this from Todo to In Progress in ENF Engineering Jul 13, 2022
@oschwaldp-oci oschwaldp-oci mentioned this issue Jul 13, 2022
Merged
oschwaldp-oci added a commit that referenced this issue Jul 13, 2022
@oschwaldp-oci
Merge pull request #670 from eosnetworkfoundation/merge-3.1.x-into-main
dc78df1 
[3.1 -> main] Bring GH-651 and GH-646 into main
@heifner
Copy link
Member

heifner commented Jul 14, 2022

Resolved by #654

@heifner heifner closed this as completed Jul 14, 2022
Repository owner moved this from In Progress to Done in ENF Engineering Jul 14, 2022
@bhazzard bhazzard mentioned this issue Feb 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschwaldp-oci oschwaldp-oci

Labels
3.1 Candidates OCI OCI working this issue...
Projects
ENF Engineering
Status: Done
Milestone
Mandel 3.1.0-rc3
Development

No branches or pull requests
5 participants
@heifner @fschoell @oschwaldp-oci @matthewdarwin @stephenpdeos