be explict about softfloat's float128_t usage instead of boost::float128_t; fixes boost 1.80 build #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abi_serializer.cpp
does aApparently something internal to boost has been reorganized and when building with boost 1.80 beta it appears this
pack_unpack<float128_t>()
is getting confused withboost::float128_t
(gets atemplate argument deduction/substitution failed
error).Be explicit here that we want softfloat's
float128_t
.Sending this in to 3.1 since confusion around this type seems like a Bad Thing. I wonder if we should blanket replace all
float128_t
with::float128_t
elsewhere though?