Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be explict about softfloat's float128_t usage instead of boost::float128_t; fixes boost 1.80 build #638

Closed
wants to merge 1 commit into from

Conversation

spoonincode
Copy link
Member

abi_serializer.cpp does a

using namespace boost;

Apparently something internal to boost has been reorganized and when building with boost 1.80 beta it appears this pack_unpack<float128_t>() is getting confused with boost::float128_t (gets a template argument deduction/substitution failed error).

Be explicit here that we want softfloat's float128_t.

Sending this in to 3.1 since confusion around this type seems like a Bad Thing. I wonder if we should blanket replace all float128_t with ::float128_t elsewhere though?

@heifner
Copy link
Member

heifner commented Jul 11, 2022

I wonder if we should blanket replace all float128_t with ::float128_t elsewhere though?

I would vote, yes. If/when float128_t added to C++ it will likely be in namespace std. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p1467r5.html . Seems like we would be better served to be explicit. Maybe even better to declare our own using soft_float128_t = ::float128_t

@spoonincode
Copy link
Member Author

hm yeah let me think that over some

@spoonincode spoonincode marked this pull request as draft July 11, 2022 14:33
@spoonincode spoonincode changed the title [3.1] be explict about softfloat's float128_t usage instead of boost::float128_t; fixes boost 1.80 build be explict about softfloat's float128_t usage instead of boost::float128_t; fixes boost 1.80 build Jul 19, 2022
@spoonincode
Copy link
Member Author

replaced by #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants