Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make softfloat type usage more explict #768

Closed
spoonincode opened this issue Jul 20, 2022 · 1 comment
Closed

make softfloat type usage more explict #768

spoonincode opened this issue Jul 20, 2022 · 1 comment

Comments

@spoonincode
Copy link
Member

spoonincode commented Jul 20, 2022

See #638 & #702 & their comments for a little initial context.

We should be more explicit across the code when a float128_t (or potentially other softfloat types) is intended to really be a softfloat float128_t. Otherwise it's at risk of getting mixed up with a boost::float128_t or a future std::float128_t.

Some possibilities include placing the softfloat types in to a namespace and/or some sort of using soft_float128_t = softfloat::float128_t alias.

@ericpassmore ericpassmore transferred this issue from eosnetworkfoundation/mandel Aug 6, 2022
@ericpassmore ericpassmore transferred this issue from another repository Aug 6, 2022
@spoonincode
Copy link
Member Author

moved to AntelopeIO/spring#522

@spoonincode spoonincode closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in ENF Engineering Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant