Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] skip context free actions during light validation #551

Merged
merged 9 commits into from
Jun 30, 2022

Conversation

ClaytonCalabrese
Copy link
Contributor

@ClaytonCalabrese ClaytonCalabrese commented Jun 28, 2022

Skip context_free_action execution during light validation.
Since context free actions are designed not have any side-effects (except for possible console output) and to only influence execution via asserting, the fact that they exist in a signed block is indication that the producer executed them and they didn't assert. Therefore, they can be skipped during light validation where producers are implicitly trusted.
Any node that wishes to include all context free action console output in action traces needs to run with --force-all-checks for replay, run with no trusted producers, and run in full validation mode. NOTE: this is currently not completely accurate as it depends on PR Skip checks [ #8848]

Part of #188

Backports EOSIO/eos#8846
Resolves: #556

@ClaytonCalabrese ClaytonCalabrese added 3.2 Candidate OCI OCI working this issue... labels Jun 28, 2022
@ClaytonCalabrese ClaytonCalabrese self-assigned this Jun 28, 2022
@ClaytonCalabrese ClaytonCalabrese changed the title skip context free actions during light validation [3.2] skip context free actions during light validation Jun 28, 2022
@ClaytonCalabrese
Copy link
Contributor Author

Resolves: #556

@ClaytonCalabrese ClaytonCalabrese merged commit 2d10053 into main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 Candidate OCI OCI working this issue...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport: skip context free actions during light validation
2 participants