Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port various nodeos light validation improvements #188

Closed
2 tasks done
spoonincode opened this issue May 6, 2022 · 2 comments
Closed
2 tasks done

port various nodeos light validation improvements #188

spoonincode opened this issue May 6, 2022 · 2 comments
Assignees
Labels
seeking feedback Looking for community feedback on this issue
Milestone

Comments

@spoonincode
Copy link
Member

spoonincode commented May 6, 2022

nodeos has the ability to run in light validation mode. In this mode actions are executed but some parts of protocol validation are skipped as if a light client would. For example, checking that the signatures on the transaction fulfill required authorities.

In 2.1 various improvements were made to nodeos' light validation mode. For example (and we'll add more here as discover them):

The improvements are mostly with regard to not executing context free actions in light validation mode.

I would guess it's fairly rare for someone to run nodeos in light validation mode as it doesn't really improve performance much, so from that standpoint porting these over seems unnecessary. But, these changes do allow exercising and testing important protocol behaviors and on first look seem to be fairly self contained (not intertwined with the functionality that actually removes CFA from block logs, which is something we're definitely not interested in porting!), so maybe it's fine to just bring them along.

EDIT:

We decided not to port EOSIO/eos#8856 or EOSIO/eos#8851.

However, the remaining two items should still be ported. They are tracked by the following two issues:

@spoonincode spoonincode added the seeking feedback Looking for community feedback on this issue label May 6, 2022
@ClaytonCalabrese ClaytonCalabrese self-assigned this Jun 27, 2022
@arhag arhag added this to the Mandel 3.2.0-rc1 milestone Jul 1, 2022
@arhag arhag moved this to Todo in ENF Engineering Jul 1, 2022
@arhag arhag moved this from Todo to In Progress in ENF Engineering Jul 1, 2022
@arhag
Copy link
Member

arhag commented Jul 1, 2022

@ClaytonCalabrese:

I added your list (except without the two issues we don't want to port) into @spoonincode's original comment at the top. By putting the checklist in the original comment, GitHub treats the linked issues in a special way. It treats them as tasks to be completed as part of this larger issue. And also if you visit the individual issues you will see it adds a "Tracked in #188" near the title.

I think this is a good way for us to break up large issues that track bigger items of work (e.g. some big feature or an epic) into smaller tasks that can be started and completed within a biweekly sprint. As the individual tasks are completed, we would make sure that the checkbox is marked to show progress on the larger issue. If all tasks of the larger issue are completed, then we would make sure to also close the larger issue as "Close as completed". That last step is also important in helping us track completion of the larger feature/epic as part of the milestones.

FYI @heifner: want to make sure you also saw the above and get your feedback.

Repository owner moved this from In Progress to Done in ENF Engineering Jul 1, 2022
@stephenpdeos stephenpdeos modified the milestones: Mandel 3.2.0-rc1, Mandel 3.2.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seeking feedback Looking for community feedback on this issue
Projects
Status: Done
Development

No branches or pull requests

4 participants