Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Separate out signature provider from producer plugin #541

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 25, 2022

Currently the only time nodeos needs to perform a signature is when signing a block. Thus defining keys and where to find the private key for those keys has been in producer plugin.

Going forward though, this may not be the only use case for signing in nodeos.

Move the signature provider code out of producer plugin to its own plugin so that any plugin can leverage signing through a single impl.

Backports: EOSIO/eos#9066 & EOSIO/eos#9079

Resolves #540
Resolves #521

@heifner heifner added the OCI OCI working this issue... label Jun 25, 2022
@spoonincode
Copy link
Member

The only reason this was separated out in the first place was for witness_plugin which of course is no more. I mean I guess it doesn't hurt anything but doesn't really gain anything either; any particular reason was interested to port it?

@heifner
Copy link
Member Author

heifner commented Jun 27, 2022

The only reason this was separated out in the first place was for witness_plugin which of course is no more. I mean I guess it doesn't hurt anything but doesn't really gain anything either; any particular reason was interested to port it?

Seemed like a nice separation of concerns, but I'm ok with just closing this out and not backporting.

@heifner
Copy link
Member Author

heifner commented Jun 28, 2022

Seemed like a nice separation of concerns, but I'm ok with just closing this out and not backporting.

@larryk85 @arhag opinions?

@larryk85
Copy link
Contributor

Seemed like a nice separation of concerns, but I'm ok with just closing this out and not backporting.

@larryk85 @arhag opinions?

I agree it does. Only a million more spots to go to get really good separation of concerns across the project 😃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI OCI working this issue...
Projects
None yet
3 participants