Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix setting of keosd-provider-timeout #9079

Merged
merged 1 commit into from
May 12, 2020
Merged

Fix setting of keosd-provider-timeout #9079

merged 1 commit into from
May 12, 2020

Conversation

heifner
Copy link
Contributor

@heifner heifner commented May 12, 2020

Change Description

  • On Ubuntu & Boost 1.70 (no idea if this is isolated to this platform)
  • The keosd-provider-timeout config option notifier was getting called after make_keosd_signature_provider so the lambda was capturing the unset value of _keosd_provider_timeout_us (0) setting a deadline of now so that keosd always timed out.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner
Set keosd-provider-timeout in signature_provider_plugin::plugin_initi…
e23e808 
…alize because make_keosd_signature_provider was capturing 0 before boost notifier was called.
@heifner heifner requested a review from spoonincode May 12, 2020 16:06
@heifner heifner merged commit fc2a339 into develop May 12, 2020
@heifner heifner deleted the sig-provider-deadline-dev branch May 12, 2020 16:59
@vladtr vladtr mentioned this pull request Jun 24, 2022
Closed
@heifner heifner mentioned this pull request Jun 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @spoonincode