Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] misc pinned build script fixes #532

Merged
merged 4 commits into from
Jun 24, 2022
Merged

[3.1] misc pinned build script fixes #532

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
920aac4
use /usr/bin/env to find bash
spoonincode Jun 24, 2022
ecdb730
don't use cmake -S as that doesn't work on cmake 3.10
spoonincode Jun 24, 2022
cfdce01
remove unused LIBPQXX variable
spoonincode Jun 24, 2022
a4fa84d
add python3 in install_deps.sh
spoonincode Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/pinned_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ pushdir ${MANDEL_DIR}

# build Mandel
echo "Building Mandel ${SCRIPT_DIR}"
try cmake -DCMAKE_TOOLCHAIN_FILE=${SCRIPT_DIR}/pinned_toolchain.cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=${LLVM_DIR}/lib/cmake -DCMAKE_PREFIX_PATH=${BOOST_DIR}/bin -S${SCRIPT_DIR}/..
try cmake -DCMAKE_TOOLCHAIN_FILE=${SCRIPT_DIR}/pinned_toolchain.cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=${LLVM_DIR}/lib/cmake -DCMAKE_PREFIX_PATH=${BOOST_DIR}/bin ${SCRIPT_DIR}/..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So will we add -S back after Ubuntu 18.04 retires?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is much utility in it how we're using it; it's more interesting when running cmake outside of both the source & build directory.

try make -j${JOBS}
try cpack
Expand Down