Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] misc pinned build script fixes #532

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

spoonincode
Copy link
Member

Resolves #356 but also other issues I've encountered when using the script on all Ubuntu versions: python needs to be installed, and on Ubuntu 18 it's an old cmake so can't use -S argument on cmake

@@ -130,7 +130,7 @@ pushdir ${MANDEL_DIR}

# build Mandel
echo "Building Mandel ${SCRIPT_DIR}"
try cmake -DCMAKE_TOOLCHAIN_FILE=${SCRIPT_DIR}/pinned_toolchain.cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=${LLVM_DIR}/lib/cmake -DCMAKE_PREFIX_PATH=${BOOST_DIR}/bin -S${SCRIPT_DIR}/..
try cmake -DCMAKE_TOOLCHAIN_FILE=${SCRIPT_DIR}/pinned_toolchain.cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=${LLVM_DIR}/lib/cmake -DCMAKE_PREFIX_PATH=${BOOST_DIR}/bin ${SCRIPT_DIR}/..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So will we add -S back after Ubuntu 18.04 retires?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is much utility in it how we're using it; it's more interesting when running cmake outside of both the source & build directory.

@spoonincode spoonincode merged commit 96003fc into release/3.1.x Jun 24, 2022
@spoonincode spoonincode deleted the misc_build_script_stuff_31x branch June 24, 2022 19:48
@arhag arhag changed the title misc pinned build script fixes - 3.1 [3.1] misc pinned build script fixes Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants