Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify flake threshold for hotrestart_handoff_test #33966

Merged
merged 2 commits into from
May 10, 2024
Merged

Modify flake threshold for hotrestart_handoff_test #33966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df70e32
Increase flake threshold for hotrestart_handoff_test
ravenblackx May 6, 2024
7668d1b
Actually *lower* the value instead.
ravenblackx May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/integration/python/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ envoy_package()

envoy_py_test(
name = "hotrestart_handoff_test",
size = "medium",
# This is not actually large, but setting large makes the test skip for
# asan and tsan.
size = "large",
srcs = select({
"//bazel:disable_hot_restart_or_admin": ["null_test.py"],
"//conditions:default": ["hotrestart_handoff_test.py"],
Expand Down
13 changes: 8 additions & 5 deletions test/integration/python/hotrestart_handoff_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,21 @@ def random_loopback_host():
# This is a timeout that must be long enough that the hot restarted
# instance can reliably be fully started up within this many seconds, or the
# test will be flaky. 3 seconds is enough on a not-busy host with a non-tsan
# non-coverage build; 10 seconds should be enough to be not flaky in most
# non-coverage build; 6 seconds should be enough to be not flaky in most
# configurations.
#
# Unfortunately, because the test is verifying the behavior of a connection
# during drain, the first connection must last for the full tolerance duration,
# so increasing this value increases the duration of the test. For this
# reason we want to keep it as low as possible without causing flaky failure.
#
# Ideally this would be adjusted (3x) for tsan and coverage runs, but making that
# possible for python is outside the scope of this test, so we're stuck using the
# 3x value for all tests.
STARTUP_TOLERANCE_SECONDS = 10
# If this goes longer than 10 seconds connections start timing out which
# causes the test to get stuck and time out. Unfortunately for tsan or asan
# runs the "long enough to start up" constraint fights with the "too long for
# connections to be idle" constraint. Ideally this test would be disabled for
# those slower test contexts, but we don't currently have infrastructure for
# that.
STARTUP_TOLERANCE_SECONDS = 6

# We send multiple requests in parallel and require them all to function correctly
# - this makes it so if something is flaky we're more likely to encounter it, and
Expand Down