Modify flake threshold for hotrestart_handoff_test #33966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <ravenblack@dropbox.com>
|
/wait for ci fixes |
phlax
previously approved these changes
May 9, 2024
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Modify flake threshold for hotrestart_handoff_test
Additional Description: #33251 appears to be a racy flake due to tsan runs being slower. This adjustment is hopefully enough to keep it from flaking. If it continues to flake, it's probably worth considering making this test skipped for *san tests rather than increasing the tolerance any further, since integration tests don't really benefit much from *san anyway.
Turns out increasing the tolerance threshold actually makes the situation worse - it must be long enough for another envoy instance to fully start up, but also shorter than (some sort of connection idle timeout that occurs in quiche).
Risk Level: None, test-only.
Testing: Yes it is.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a