Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_grpc: add a runtime flag to disable TLSv1.3 #32690

Closed
wants to merge 2 commits into from
Closed

google_grpc: add a runtime flag to disable TLSv1.3 #32690

wants to merge 2 commits into from

Conversation

briansonnenberg
Copy link
Contributor

Backport of #32235 and #32315

publish-envoy bot and others added 2 commits March 4, 2024 17:28
@publish-envoy @briansonnenberg
deps: Bump com_github_grpc_grpc -> 1.49.4
9725828 
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: publish-envoy[bot] <140627008+publish-envoy[bot]@users.noreply.github.com>
@kyessenov @briansonnenberg
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32532)
df6e00d 
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 4, 2024
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #32690 was opened by briansonnenberg.

see: more, trace.

@RyanTheOptimist
Copy link
Contributor

Looks like DCO needs to be fixed.

In any case, 1.25 hit end of life as of January, according to https://github.com/envoyproxy/envoy/blob/main/RELEASES.md Why are we back porting to and end-of-life version?

/wait

@kyessenov
Copy link
Contributor

This should be sent to a fork, sorry :) 1.25 is used in production, but we don't expect Envoy to cut another 1.25 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RyanTheOptimist RyanTheOptimist

Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briansonnenberg @RyanTheOptimist @kyessenov