Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.29] google_grpc: add a runtime flag to disable TLSv1.3 #32532

Merged
merged 2 commits into from
Feb 23, 2024
Merged

[1.29] google_grpc: add a runtime flag to disable TLSv1.3 #32532

merged 2 commits into from
Feb 23, 2024

Conversation

kyessenov
Copy link
Contributor

Backport of #32315

@kyessenov
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)
179acbb 
Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #32532 was opened by kyessenov.

see: more, trace.

@kyessenov kyessenov requested a review from phlax February 23, 2024 00:10
@kyessenov
backport envoyproxy#32315
40a26bd 
Change-Id: I5b5ec42d5b3138060505c74d313d759199083e8d
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov force-pushed the google_grpc_fips_1_29 branch from 13a885d to 40a26bd Compare February 23, 2024 00:23
@kyessenov kyessenov changed the title google_grpc: add a runtime flag to disable TLSv1.3 [1.29] google_grpc: add a runtime flag to disable TLSv1.3 Feb 23, 2024
@phlax phlax merged commit 47766f0 into envoyproxy:release/v1.29 Feb 23, 2024
41 checks passed
kyessenov added a commit to kyessenov/envoy that referenced this pull request Feb 23, 2024
@kyessenov
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32532)
e0dab17 
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov added a commit to kyessenov/envoy that referenced this pull request Feb 23, 2024
@kyessenov
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32532)
d101b31 
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov added a commit to kyessenov/envoy that referenced this pull request Feb 23, 2024
@kyessenov
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32532)
e7902b7 
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
briansonnenberg pushed a commit to briansonnenberg/envoy that referenced this pull request Mar 4, 2024
@kyessenov @briansonnenberg
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32532)
df6e00d 
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
phlax pushed a commit that referenced this pull request Mar 4, 2024
@kyessenov @phlax
google_grpc: add a runtime flag to disable TLSv1.3 (#32532)
ca49fd6 
* google_grpc: add a runtime flag to disable TLSv1.3 (#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
phlax pushed a commit that referenced this pull request Mar 4, 2024
@kyessenov @phlax
google_grpc: add a runtime flag to disable TLSv1.3 (#32532)
3abf413 
* google_grpc: add a runtime flag to disable TLSv1.3 (#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
phlax pushed a commit that referenced this pull request Mar 5, 2024
@kyessenov @phlax
google_grpc: add a runtime flag to disable TLSv1.3 (#32532)
3db916f 
* google_grpc: add a runtime flag to disable TLSv1.3 (#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
SeanKilleen pushed a commit to SeanKilleen/envoy that referenced this pull request Apr 3, 2024
@kyessenov @SeanKilleen
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32532)
a7c8999 
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizan lizan lizan approved these changes

@phlax phlax Awaiting requested review from phlax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyessenov @lizan @phlax