Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.28] google_grpc: add a runtime flag to disable TLSv1.3 (#32532) #32555

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[1.28] google_grpc: add a runtime flag to disable TLSv1.3 (#32532) #32555

merged 1 commit into from
Mar 4, 2024

Conversation

kyessenov
Copy link
Contributor

Backport of #32315

@kyessenov
google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32532)
e0dab17 
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <kuat@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #32555 was opened by kyessenov.

see: more, trace.

@mattklein123 mattklein123 self-assigned this Feb 26, 2024
@phlax phlax merged commit ca49fd6 into envoyproxy:release/v1.28 Mar 4, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyessenov @mattklein123 @phlax