Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwt: do not concatenate duplicated headers #32248

Merged
merged 7 commits into from
Feb 12, 2024

Add a release note

28a78a6
Select commit
Loading
Failed to load commit list.
Merged

jwt: do not concatenate duplicated headers #32248

Add a release note
28a78a6
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/TSAN skipped Feb 9, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/32248/main@28a78a6)

jewertow @jewertow 28a78a6 #32248 merge main@610afbf

jwt: do not concatenate duplicated headers

Commit Message: jwt: do not concatenate duplicated headers
Additional Description:
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens.
This PR fixes #31468.

Risk Level:
Testing: unit tests
Docs Changes: none
Release Notes:
Platform Specific Features: none

Environment

Request variables

Key Value
ref b9f6f7adbcace7117c61e3af00d2701dc50f73c1
sha 28a78a6
pr 32248
base-sha 610afbf
actor jewertow @jewertow
message jwt: do not concatenate duplicated headers...
started 1707519315.767821
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true