deps/mobile: Bump bazel -> 6.3.1, rules_java -> 6.4.0, io_bazel_rules_kotlin -> 1.8
#28854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
not sure if this will work and whether bazelbuild/rules_java#64 is resolved - but essentially trying to unblock bazel upgrade |
c4b26b8 to
a70e1f2
Compare
rules_java -> 6.4.0bazel -> 6.3.1, rules_java -> 6.4.0
RyanTheOptimist
previously approved these changes
Aug 8, 2023
|
/retest mobile transients |
bazel -> 6.3.1, rules_java -> 6.4.0bazel -> 6.3.1, rules_java -> 6.4.0, io_bazel_rules_kotlin -> 1.8
|
/retest |
11d31ae to
f51393d
Compare
|
/retest mobile |
|
/retest |
f26f430 to
1854103
Compare
keith
approved these changes
Aug 10, 2023
| strip_prefix = "rules_java-6.4.0", | ||
| url = "https://github.com/bazelbuild/rules_java/archive/6.4.0.tar.gz", | ||
| patch_args = ["-p1"], | ||
| patches = ["@envoy//bazel:rules_java.patch"], |
There was a problem hiding this comment.
should we have a TODO for when we can drop this patch?
There was a problem hiding this comment.
i can add - when is that ?
There was a problem hiding this comment.
I'm not sure, i guess when that linked issue is fixed, or bazelbuild/bazel#17085
|
@keith unfortunately its still failing mobile CI - we are now down to issues related to the rules_java upgade - any help resolving these would be much appreciated! |
1854103 to
920f1f5
Compare
keith
approved these changes
Aug 10, 2023
920f1f5 to
f72b133
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
f72b133 to
2923310
Compare
RyanTheOptimist
approved these changes
Aug 11, 2023
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 16, 2023
…rules_kotlin` -> 1.8 (envoyproxy#28854) Signed-off-by: Ryan Northey <ryan@synca.io> Co-authored-by: Ryan Hamilton <rch@google.com>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 16, 2023
…rules_kotlin` -> 1.8 (envoyproxy#28854) Signed-off-by: Ryan Northey <ryan@synca.io> Co-authored-by: Ryan Hamilton <rch@google.com> Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 17, 2023
…o_bazel_rules_kotlin` -> 1.8 (envoyproxy#28854)" This reverts commit b9d9a74. Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 17, 2023
…o_bazel_rules_kotlin` -> 1.8 (envoyproxy#28854)" This reverts commit b9d9a74. Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 17, 2023
….4.0, `io_bazel_rules_kotlin` -> 1.8 (envoyproxy#28854)"" This reverts commit c7147a8. Signed-off-by: Ryan Northey <ryan@synca.io>
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Aug 17, 2023
…o_bazel_rules_kotlin` -> 1.8 (envoyproxy#28854)" This reverts commit b9d9a74.
phlax
added a commit
that referenced
this pull request
Aug 21, 2023
…rules_kotlin` -> 1.8 (#28854) Signed-off-by: Ryan Northey <ryan@synca.io> Co-authored-by: Ryan Hamilton <rch@google.com>
phlax
added a commit
that referenced
this pull request
Aug 22, 2023
…rules_kotlin` -> 1.8 (#28854) Signed-off-by: Ryan Northey <ryan@synca.io> Co-authored-by: Ryan Hamilton <rch@google.com> Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]