Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] deps: Bump bazel -> 6.3.1 #28850

Closed
wants to merge 1 commit into from
Closed

Conversation

phlax
Copy link
Member

@phlax phlax commented Aug 5, 2023

Another attempt at #27315

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax
Copy link
Member Author

phlax commented Aug 5, 2023

there are an increasing number of developments in upstream that we want i think (eg improved coverage support)

iirc there is an issue with mobile <> rules_java which we need to resolve

@phlax
Copy link
Member Author

phlax commented Aug 5, 2023

/retest mobile

@phlax
Copy link
Member Author

phlax commented Aug 5, 2023

mobile fail is:

ERROR: /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/external/rules_java/toolchains/BUILD:116:14: no such package '@remote_java_tools_darwin//': The repository '@remote_java_tools_darwin' could not be resolved: Repository '@remote_java_tools_darwin' is not defined and referenced by '@rules_java//toolchains:ijar_prebuilt_binary_darwin'
ERROR: Analysis of target '//test/kotlin/io/envoyproxy/envoymobile:grpc_stream_test' failed; build aborted: 

https://github.com/envoyproxy/envoy/actions/runs/5770495145/job/15644081022#step:5:24

cc @keith

@phlax
Copy link
Member Author

phlax commented Aug 5, 2023

attempt to upgrade rules_java here #28854

@htuch htuch self-assigned this Aug 6, 2023
@phlax phlax force-pushed the deps-bump-bazel branch 3 times, most recently from a685e7e to 01a8195 Compare August 8, 2023 13:25
@phlax phlax changed the title deps: Bump bazel -> 6.3.1 [WIP] deps: Bump bazel -> 6.3.1 Aug 8, 2023
@phlax phlax marked this pull request as draft August 8, 2023 13:47
@phlax
Copy link
Member Author

phlax commented Aug 8, 2023

other than mobile fails, this also seems to break the package distro verification

i need to test further but it seems some issue with docker and/or bazel/rbe config

@phlax phlax force-pushed the deps-bump-bazel branch from 01a8195 to cf9a64c Compare August 8, 2023 14:27
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the deps-bump-bazel branch from cf9a64c to d1c65cb Compare August 8, 2023 18:10
@phlax
Copy link
Member Author

phlax commented Aug 9, 2023

closing in favour of #28854

@phlax phlax closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants