-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] bazel: Set RBE downloads to minimal #22017
Conversation
this seems to make the problem described in bazelbuild/bazel#11834 worse, and prevents the workaround from working - investigating further... |
435d81c
to
df44548
Compare
this seems to speed up CI considerably (and local RBE) the one gotcha is the workaround in CI - as this is kinda already the case - just the workaround has changed - im thinking we should still add we might want to add some docs somewhere about the known issue if it affects local RBE without running through the ci codepath one option might be to use |
strange CI seems to not dl the pkg files at all - not sure why it is different locally |
1d94f7b
to
96aa4dc
Compare
|
that doesnt seem to be it - docs fail in CI and dont run anything that consumes the docs beforehand and it is failing - locally never fails |
Fix envoyproxy#21946 Signed-off-by: Ryan Northey <ryan@synca.io>
541bc35
to
72ae31e
Compare
so it seems the reason i was downloading so much is that i didnt have the toplevel config activated i now also understand that not sure exactly why but this still saves 25% from the job to build x86 - i guess this is more to do with |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
72ae31e
to
271abe2
Compare
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Testing RBE locally and it can in many cases take longer downloading files than it would have done just running locally
Partly i think (mis)use ofi wasnt using the CI configpkg_tars
is to blame, and there are defo some optis that we could add, but i also think we want this set to minimal if possibleRisk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]