Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote_download_toplevel doesn't download binary after testing #11834

Closed
Tracked by #12665
lizan opened this issue Jul 24, 2020 · 0 comments
Closed
Tracked by #12665

remote_download_toplevel doesn't download binary after testing #11834

lizan opened this issue Jul 24, 2020 · 0 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug

Comments

@lizan
Copy link

lizan commented Jul 24, 2020

Description of the problem / feature request:

When --remote_download_toplevel is specified,

bazel test --remote_download_toplevel //test/...
bazel build --remote_download_toplevel <some_binary>

doesn't download <some_binary> while downloading binary is expected.

Running build first or clean some artifacts before build will be workaround.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

From envoy master, do test //test/exe/... and build //source/exe:envoy-static

What operating system are you running Bazel on?

Ubuntu 18.04

What's the output of bazel info release?

3.4.1

Any other information, logs, or outputs that you want to share?

It is possible because the test targets has the binary in its dependency so somehow bazel treated it is already downloaded, while test with --remote_download_toplevel does't download the binary itself.

lizan added a commit to lizan/envoy that referenced this issue Jul 24, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@oquenchil oquenchil added team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug untriaged labels Jul 28, 2020
@coeuvre coeuvre added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Dec 9, 2020
@coeuvre coeuvre self-assigned this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants