Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/datetime editor #815

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Conversation

midhun-pm
Copy link
Contributor

Fixes #808
Must only be merged in after #814

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should be fine to merge once #814 has gone in and master has been merged into this branch.

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #815 into master will increase coverage by 0.28%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   72.13%   72.41%   +0.28%     
==========================================
  Files          51       51              
  Lines        6363     6363              
  Branches     1274     1274              
==========================================
+ Hits         4590     4608      +18     
+ Misses       1383     1362      -21     
- Partials      390      393       +3
Impacted Files Coverage Δ
traits/api.py 90.32% <ø> (ø) ⬆️
traits/trait_list_object.py 75.09% <ø> (ø) ⬆️
traits/trait_dict_object.py 75.44% <ø> (ø) ⬆️
traits/trait_set_object.py 67.11% <ø> (ø) ⬆️
traits/editor_factories.py 81.25% <0%> (ø) ⬆️
traits/trait_types.py 69.73% <100%> (-0.17%) ⬇️
traits/traits.py 76.92% <0%> (+4.04%) ⬆️
traits/etsconfig/etsconfig.py 63.8% <0%> (+6.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22193d5...f5f4ea0. Read the comment docs.

@mdickinson mdickinson merged commit dc3f562 into master Jan 24, 2020
@mdickinson mdickinson deleted the documentation/datetime_editor branch January 24, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datetime_editor is not documented
3 participants