Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DateTime trait to Datetime trait #814

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

midhun-pm
Copy link
Contributor

Fixes #811

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #814 into master will increase coverage by 0.28%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   72.13%   72.41%   +0.28%     
==========================================
  Files          51       51              
  Lines        6363     6363              
  Branches     1274     1274              
==========================================
+ Hits         4590     4608      +18     
+ Misses       1383     1362      -21     
- Partials      390      393       +3
Impacted Files Coverage Δ
traits/api.py 90.32% <ø> (ø) ⬆️
traits/editor_factories.py 81.25% <0%> (ø) ⬆️
traits/trait_types.py 69.73% <100%> (-0.17%) ⬇️
traits/traits.py 76.92% <0%> (+4.04%) ⬆️
traits/etsconfig/etsconfig.py 63.8% <0%> (+6.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27210f5...18562d6. Read the comment docs.

@mdickinson
Copy link
Member

There are a couple of DateTimes persisting in the source:

(traits) mirzakhani:traits mdickinson$ grin "\bDateTime\b"
./traits/editor_factories.py:
  173 :     editing DateTime values.
./traits/trait_types.py:
 3591 : # -- DateTime Trait definition ------------------------------------------------

Apart from that, looks good.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of missed DateTimes (already commented); apart from that, LGTM.

I'm assuming that we'll rename DateTimeEditor separately (probably in a pair of PRs against Traits and TraitsUI).

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 0d263b2 into master Jan 24, 2020
@mdickinson mdickinson deleted the rename/DateTime_to_Datetime branch January 24, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename DateTime to Datetime
3 participants