Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove TraitSetObject.copy #759

Merged
merged 1 commit into from
Jan 17, 2020
Merged

remove TraitSetObject.copy #759

merged 1 commit into from
Jan 17, 2020

Conversation

shoeb-github
Copy link
Contributor

closes #733

  • As explained in the issue, this is no longer needed in Python 3.

@shoeb-github shoeb-github self-assigned this Jan 16, 2020
@codecov-io
Copy link

codecov-io commented Jan 16, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2e5a601). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #759   +/-   ##
=========================================
  Coverage          ?   71.78%           
=========================================
  Files             ?       51           
  Lines             ?     6331           
  Branches          ?     1280           
=========================================
  Hits              ?     4545           
  Misses            ?     1388           
  Partials          ?      398
Impacted Files Coverage Δ
traits/trait_set_object.py 67.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5a601...71048aa. Read the comment docs.

mdickinson
mdickinson approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit a2b8942 into master Jan 17, 2020
@mdickinson mdickinson deleted the maint/remove-copy-from-TraitSetObject branch January 17, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees

@shoeb-github shoeb-github

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove TraitSetObject.copy.
3 participants
@shoeb-github @codecov-io @mdickinson