Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TraitSetObject.copy. #733

Closed
mdickinson opened this issue Jan 10, 2020 · 1 comment · Fixed by #759
Closed

Remove TraitSetObject.copy. #733

mdickinson opened this issue Jan 10, 2020 · 1 comment · Fixed by #759
Assignees
@shoeb-github
Labels
good first issue
Milestone
6.0.0 release

Comments

@mdickinson
Copy link
Member

Now that we're Python 3 only, we don't need TraitSetObject.copy any more. It's harmless, except in that it misleads people (me) into expecting that TraitDictObject.copy and TraitListObject.copy should exist, too.

OTOH, we should also make sure that there are tests for calling the .copy method on the value of a Set trait.

See #97, #98.
@mdickinson mdickinson added this to the 6.0.0 release milestone Jan 10, 2020
@mdickinson
Copy link
Member Author

we should also make sure that there are tests

Scratch that. @rkern already added a test in #98.

@shoeb-github shoeb-github self-assigned this Jan 16, 2020
@shoeb-github shoeb-github mentioned this issue Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoeb-github shoeb-github

Labels
good first issue
Projects
None yet
Milestone
6.0.0 release
Development

Successfully merging a pull request may close this issue.

remove TraitSetObject.copy enthought/traits
2 participants
@mdickinson @shoeb-github