Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards compatibility fix: make PrefixMap._map available #1578

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Backwards compatibility fix: make PrefixMap._map available #1578

merged 2 commits into from
Oct 11, 2021

Conversation

mdickinson
Copy link
Member

This PR makes PrefixMap._map available again (following its removal in #1564), to avoid breaking Mayavi.

Checklist

  • Tests

Closes #1577.

@mdickinson mdickinson mentioned this pull request Oct 11, 2021
Closed
@mdickinson
Copy link
Member Author

Added a changelog entry, for convenience when making the 6.3.1 release.

rahulporuri
rahulporuri approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 3a5ba84 into main Oct 11, 2021
@mdickinson mdickinson deleted the fix/prefix-map-subclassing branch October 11, 2021 10:52
mdickinson added a commit that referenced this pull request Oct 11, 2021
@mdickinson
Backwards compatibility fix: make PrefixMap._map available (#1578)
caf020c 
* Backwards compatibility fix for those subclassing PrefixMap

* Add changelog entry

(cherry picked from commit 3a5ba84)
@mdickinson mdickinson mentioned this pull request Oct 11, 2021
Merged
mdickinson added a commit that referenced this pull request Oct 11, 2021
@mdickinson
Prepare for 6.3.1 release (#1579)
4066fad 
* Bump version for development towards 6.3.1

* Backwards compatibility fix: make `PrefixMap._map` available (#1578)

* Backwards compatibility fix for those subclassing PrefixMap

* Add changelog entry

(cherry picked from commit 3a5ba84)
@mdickinson mdickinson added porting: backported to 6.3 This PR has been backported to the Traits 6.3.x release branch and removed porting: needs backport to 6.3 labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
porting: backported to 6.3 This PR has been backported to the Traits 6.3.x release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traits 6.3 breaks subclassing of PrefixMap
2 participants
@mdickinson @rahulporuri