You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The RevPrefixMap trait type subclasses PrefixMap and depends on its internals. PrefixMap wasn't designed for subclassing, and indeed changes in Traits 6.3 broke RevPrefixMap as a result. I'd recommend rewriting RevPrefixMap as a direct subclass of TraitType.
The text was updated successfully, but these errors were encountered:
@rahulporuri Could we aim to include a fix for this in the Mayavi 4.7.4 release, too? That would give Traits the freedom to remove its workaround.
The fix I'd propose would be to start by simply pasting the Traits 6.2.0 version of PrefixMap directly into tvtk_base, and then incrementally rewriting to collapse the RevPrefixMap -> PrefixMap -> TraitType inheritance chain to just RevPrefixMap -> TraitType. We'd need some basic unit tests for RevPrefixMap, of course.
The
RevPrefixMap
trait type subclassesPrefixMap
and depends on its internals.PrefixMap
wasn't designed for subclassing, and indeed changes in Traits 6.3 brokeRevPrefixMap
as a result. I'd recommend rewritingRevPrefixMap
as a direct subclass ofTraitType
.The text was updated successfully, but these errors were encountered: