Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove root_path from logs #1294

Merged
merged 1 commit into from
Dec 25, 2021

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented Dec 15, 2021

Closes #1290 and removes scope["root_path"] from logs and only logs scope["path"].

I could not find any other occurrences.

@euri10
Copy link
Member

euri10 commented Dec 25, 2021

thanks @aminalaee

@euri10 euri10 merged commit 66e22f8 into encode:master Dec 25, 2021
@levrik
Copy link
Contributor

levrik commented Feb 21, 2022

This change broke our monitoring a bit. We use FastAPI and mount a ASGI-app to /graphql route.
Since access logs are not really useful for GraphQL we filter them out in our monitoring to avoid a lot of noise.
Since this change access logs are logging / instead of /graphql which breaks this and makes our logs very noisy again.

@aminalaee aminalaee deleted the remove-scope-root-path-from-logs branch February 21, 2022 11:36
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove superfluous root_path from logging messages
3 participants