-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access logs for mounted apps doesnt not contain the root path #1384
Comments
thanks for that @levrik we should maybe use raw_path instead of path in
|
Thanks a lot for transitioning this into an issue. I'll give your suggestion a try and open a PR. |
I've opened a PR (#1385) which switches to |
Same issue as pgjones/hypercorn#75. This is an issue on Starlette's side: encode/starlette#1336. |
Workaround for encode/uvicorn#1384
Workaround for encode/uvicorn#1384
Workaround for encode/uvicorn#1384
Workaround for encode/uvicorn#1384
This change broke our monitoring a bit. We use FastAPI and mount a ASGI-app to
/graphql
route.Since access logs are not really useful for GraphQL we filter them out in our monitoring to avoid a lot of noise.
Since this change access logs are logging
/
instead of/graphql
which breaks this and makes our logs very noisy again.Originally posted by @levrik in #1294 (comment)
The text was updated successfully, but these errors were encountered: