Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL translation update #929

Merged
merged 5 commits into from
Jan 28, 2023
Merged

PL translation update #929

merged 5 commits into from
Jan 28, 2023

Conversation

pswid
Copy link
Contributor

@pswid pswid commented Jan 23, 2023

No description provided.

{ value: 25, label: '25%' },
{ value: 50, label: '50%' },
{ value: 75, label: '75%' },
{ value: 100, label: '100%' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really a percent value, it's the maximum number of log messages stored in RAM if the weblog tab is not active.
If the tab is active, there is no limit from esp, only from browser memory.
It's not the absolute number of messages stored in RAM, only the maximum, the real number depends on log and free heap (up to this max).
But it's to complicated to explain to users, so it does not matter if a scale point is 25, 25 msg ´, or 25% (i prefere wihout uom).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer without the %

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I understand. Sorry for the confusion but the name of the option was not very clear. I removed "%". I also changed the Polish name of this option to "Maximum buffer capacity (number of entries)". It's not a perfect name, but I think it's more understandable. Maybe it should be modified in other languages as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think it's just easier to explain the help page (which I noticed is missing in https://emsesp.github.io/docs/Configuring/#logging)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think so. However, I personally prefer solutions that do not require the use of help/manual.
What now? Should I undo the change of the option name in Polish? If you agree, I'd like to leave it as it is...

@proddy proddy merged commit 381afcb into emsesp:dev Jan 28, 2023
proddy added a commit that referenced this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants