Truncate inode number when writing to st_ino_truncated. NFC #19568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is designed to hold a potentially truncated inode number, as opposes the st_ino which hold the full 64-bit value. Fixes: #19567
|
I know you are never supposed to say such things.. but I'm not sure its worth the effort to add a test for this |
walkingeyerobot
approved these changes
Jun 8, 2023
kripken
reviewed
Jun 8, 2023
| @@ -52,7 +52,7 @@ var SyscallsLibrary = { | |||
| throw e; | |||
| } | |||
| {{{ makeSetValue('buf', C_STRUCTS.stat.st_dev, 'stat.dev', 'i32') }}}; | |||
| {{{ makeSetValue('buf', C_STRUCTS.stat.__st_ino_truncated, 'stat.ino', 'i32') }}}; | |||
| {{{ makeSetValue('buf', C_STRUCTS.stat.__st_ino_truncated, 'stat.ino >>> 0', 'i32') }}}; | |||
There was a problem hiding this comment.
What effect does this have? HEAP32[x] = y will automatically do the effect of |0 to y as it is written, won't it? Is there some subtle signed/unsigned issue I am missing?
There was a problem hiding this comment.
Oh, is it hitting the recent assertion you added @sbc100 that checks the value fits?
There was a problem hiding this comment.
Yup.. nice to see them doing their job!
kripken
approved these changes
Jun 8, 2023
|
Closing in favor of #19569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is designed to hold a potentially truncated inode number, as opposes the st_ino which hold the full 64-bit value.
Fixes: #19567