-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update __st_ino_truncated from i32 to i64 #19567
Conversation
According to system/lib/libc/musl/arch/emscripten/bits/stat.h, __st_ino_truncated is a long, so should be i64. I was running my os in such a way that I was getting large enough inodes that this was causing problems.
I think |
I guess the problem happens with @walkingeyerobot is your code sensitive to inode numbers? What is it doing with them? |
yes, this was running with |
And what is the side effect? do we assert somewhere in emscripten? Or is the code under test that failing because the number is wrong? |
emscripten is asserting, and that's failing: https://github.com/emscripten-core/emscripten/blob/main/src/parseTools.js#L383-L387
|
cc @trybka |
So we could fix my have NODERAWFS somehow truncate the inode numbers .. or we could update our headers.. |
Oh wait, it called |
This field is designed to hold a potentially truncated inode number, as opposes the st_ino which hold the full 64-bit value. Fixes: #19567
Musl needs these in order to support the linux kernel but we don't need to use the same ABI in emscripten. Fixes: #19567
Musl needs these in order to support the linux kernel but we don't need to use the same ABI in emscripten. Fixes: #19567
According to system/lib/libc/musl/arch/emscripten/bits/stat.h, __st_ino_truncated is a long, so should be i64. I was running my os in such a way that I was getting large enough inodes that this was causing problems.