-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typings for using components as selectors. #690
Conversation
@Ailrun @mgroenhoff can you 2 coordinate on this? It looks like #678 can be applied on top of this but I'm not a TypeScript expert. |
@mgroenhoff #678 is for remove redundancy between |
Okay, what do I need to change? |
@mgroenhoff I mean... this PR is about changing the typings for |
I have tested #678 and that solved my issue. Please merge that one 👍 |
What: Fix the typings to allow react components to be used as component selectors (fixes #685).
Why: Because when using Typescript 2.8.3 i get the following error:
How: I added a type to the list of allowed interpolation types.
Checklist:
Update: I changed it to only allow styled components and not regular (stateless) components.