-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react-emotion typing #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to export CreateStyled
as ThemedReactEmotionInterface
as well so that it doesn't break people who are using that?(just to be clear I don't mean renaming it, I mean exporting CreateStyled
and ThemedReactEmotionInterface
where the latter is an alias for CreateStyled
)
Hm, OK. Are there any more alias I should add? |
425a63e
to
db28a9f
Compare
@mitchellhamilton Could I ask one question? If this is merged, when it will be published? |
3c896df
to
4365715
Compare
@mitchellhamilton Please let me know the problems of (or your opinion about) this PR. |
Just tested this PR on my project. Looks good to me and fixes #672 nicely. Thank you! Eagerly waiting for the release :) |
What: Fixing react-emotion typing
Why: Current typing is redundant.
How: Using
create-emotion-styled
typingChecklist:
I will send a PR for fixing typescript document after this PR is merged.