Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-emotion typing #678

Merged
merged 6 commits into from
Jun 7, 2018
Merged

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented May 26, 2018

What: Fixing react-emotion typing

Why: Current typing is redundant.

How: Using create-emotion-styled typing

Checklist:

  • [N/A] Documentation
  • Tests
  • Code complete

I will send a PR for fixing typescript document after this PR is merged.

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to export CreateStyled as ThemedReactEmotionInterface as well so that it doesn't break people who are using that?(just to be clear I don't mean renaming it, I mean exporting CreateStyled and ThemedReactEmotionInterface where the latter is an alias for CreateStyled)

@Ailrun
Copy link
Member Author

Ailrun commented May 26, 2018

Hm, OK. Are there any more alias I should add?

@Ailrun Ailrun force-pushed the typing/react-emotion branch from 425a63e to db28a9f Compare May 26, 2018 06:54
@Ailrun
Copy link
Member Author

Ailrun commented May 30, 2018

@mitchellhamilton Could I ask one question? If this is merged, when it will be published?

@Ailrun Ailrun force-pushed the typing/react-emotion branch from 3c896df to 4365715 Compare June 4, 2018 22:30
@Ailrun
Copy link
Member Author

Ailrun commented Jun 6, 2018

@mitchellhamilton Please let me know the problems of (or your opinion about) this PR.
I'd like to see typings of this PR in following release.

@esamattis
Copy link

Just tested this PR on my project. Looks good to me and fixes #672 nicely. Thank you!

Eagerly waiting for the release :)

@emmatown emmatown merged commit 185d377 into emotion-js:master Jun 7, 2018
emmatown pushed a commit that referenced this pull request Jun 7, 2018
**What**: Update typescript document

**Why**: Typings are changed, so document is outdated.

<!-- Have you done all of these things?  -->
**Checklist**:
- [x] Documentation
- [N/A] Tests
- [N/A] Code complete

This document depends on #678 and #680, so please do not merge this before them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants